I use Nikwax on my polycotton smock. It does provide some water resistance for a few weeks, but it wears off.
Nikwax/Paramo clothing works pretty well, it takes up the proofing better and you can vary the degree of breathability/proofing according to the conditions. Its very popular in the UK where mild/cool wet conditions are the norm.