Swimming is nearly all upper body so it is a great cross training. You can probably get stronger and get a more specific work out for the upper body by doing the right weight lifting regimine. But swimming is a really good choice also. Weights would be more strength oriented and swimming would be more endurance oriented.