Visor always. Helps keep sun and rain off eye protection. Adjust the helmet so it doesn't block as much view.
A couple of months ago a lady I know crashed and face planted. Her visor took much of her impact and snapped -- it appeared to have saved her nose, eye socket, and mouth from more extensive damage.