Visors will interfere with your vision if you prefer low riding position. I ride relatively upright and visors still bother me, even though they do have benefits as other posters mentioned. So I use a road helmet most of the time and BMX style helmet with fewer vents on very cold days. So, basically use what feels comfortable for your purpose.

A.