For mid level bikes, I think modernizing it would add to the value, but nowhere near the cost of the parts. For high end bikes, I think it would reduce the value. Do the conversion, but save the old parts if you plan on selling it in the next couple of years.