I have both, but prefer rollers, simply because you have to pay attention, making them less boring than a trainer. As others have stated, rollers also help you with balance and pedaling technique. Another benefit for me of rollers is that my computer sensor is on my front wheel, so I can use my computer on rollers, but not on a trainer.