I wear eyeglasses and I have a Giro with a visor. Since I typically ride after work in the evenings, I'm often riding into the setting sun. The visor is great for that. This summer I rode the GAP Trail in PA over three days, two in the rain. Again, the visor was much appreciated for keeping much of the rain off my lenses.

When it comes time to replace it, I'll get another with a visor but would probably get a brighter color (the current one is black and grey).