I had a spindle and bearing cups type of BB and have had it for 11 years but when it started getting water in and forming a rusty residue in the hub it only took 3 or 4 months to start knocking and feeling like it was rolling in the hub.

I have now replaced it with a cartridge type, hope it lasts as long as the old one did