I indulge myself on my bike spending. Did I really need another custom touring tandem or another set of Dinotte lights? I don't bother keeping track of the cost because I'm not choosing to use a bike for economic reasons, those are just the cherry on top. Heck, 95% of my miles are ridden purely for the joy of riding.

However, if one is going to consider the costs, it would make sense to do an estimation of the costs of the medical procedures that are avoided and subtract those from the cost of cycling. I suspect such an analysis would show that most of us are making money by riding, just like, on average, cyclists are adding years to their lives in spite of the few whose lives are cut short by scofflaw motorists.