On the rear I use a pair of 30+ year old Cannondale Overland panniers. Large main compartment with an internal plastic frame and 4 outside zippered pockets. Not waterproof. Still in great shape and I don't anticipate ever wanting to replace them. I spray some waterproofing on them every few years, but put anything that has to stay dry in plastic bags when I pack. The only thing I've ever done with them is replace the original top hooks with slightly larger versions that fit better on my Jandd rear rack.

On the front I use Arkel Dolphin 32 panniers I picked-up last year, which are waterproof. They have an open sleeve on the side and open pockets front and back, which are perfectly sized for extra water bottles. Sleeping bag goes in one pannier and clothes in the other.

I used to have a large Cannondale handlebar bag, which bounced around a lot, despite the shock cords. I've since replaced that with an Arkel large handlebar bag, which has a much better handlebar interface and doesn't bounce around at all.

For commuting I have a nylon Bellwether pannier on the rear. It's the one-piece kind that hangs over the rear rack and down both sides. It has tie downs that attach to the seat stays and rack. Been using it since the 1970s. Solid and in great shape. A little too small for touring, as I found out the first time I went on a tour, but it's great for city use.