Disc breaks are more reliable in wet/slushy/icy/snowy weather so I have them on my winter bike. They can also squeal like banshees if some crap gets on the rotors. Pad alignment can be a pain. Removing a wheel to change a tire can throw it off unless you get the wheel on exactly the same way, - quick release tightened the same amount, etc.

On the positive side, they aren't affected by wheel trueness. After reading for years about how great they were I was a little disappointed, but my expectations had been set pretty high.

I had a roller brake on a rear wheel for awhile. Probably didn't have the most stopping power and it weighed a ton. It also got draggy in cold weather because of the grease. But it was super easy to adjust (easier than any other type of brake I've used), worked decent in all weather, and was quiet. I like things that are quiet.