For me, I've noticed that seat height is the biggest factor in preventing knee pain. A seat positioned too low will stress my knees more than anything else.

The trick with an upright bike is to get a frame that's big enough. If you put the seat up high on a small frame then you're bending over to reach the handlebars, which eliminates the "upright" goal of riding a bike like that.