Brightness.
USB (or similar) rechargeable
Long battery life off a charge.
Easy on-switch, preferably that can be actuated with gloves on.
Easy to mount and dismount, and transferable between bikes.
Adaptable to different seat post/seat stay/handlebar/stem diameters and shapes.
Price.

Shape of the light is only considered after all the above. If at all.