Yup, it's wrong, both lights will turn on for both switch positions.

You should look for a double-throw (on-off-on), two pole switch. Right now you've got a double-throw, single pole switch.