I think there's so many better ways of attaching crank arms.

I had a bike with cotter pins as a teenager and I reckon once a year a crank would develop movement and I'd have to replace a pin. Although that could be due to my inexperience with bikes back then. Of course, cotter pins are cheap.