I presume the original question is with respect to commuting or utility cycling with a specific destination, as opposed to a recreational ride that would be a loop.
As to my choice of direct versus more scenic - it depends. For example, my commute is 18 miles via the most direct and quickest route, and my alternate route is 21 miles and hillier and has a 6 mile stretch with no traffic lights. I almost always take the direct route on the way in to work. The choice of route home depends on time constraints and whether or not I feel like riding the few extra hillier miles.