Wear whatever works for you.
A good compromise is mountain bike shorts -- they have a liner like bike shorts, but an outer layer like regular shorts. I often wear mountain bike shorts for commuting; somedays I wear regular spandex bike shorts, some day mountain bike shorts.