One thing that can prevent an otherwise good headset from keeping adjustment is if the adjustable cup's threads are a sloppy fit on the steerer's threads. You can lock the locknut against it, but any shear force makes it move against the locknut, and it comes loose straight away.

Haven't had to deal with such junk for ages, but if I did I'd try teflon tape.