I guess it's best to match the old arm length, do the measurements vary because of the length of the riders legs? or am I over thinking it?

Guessing I will have to take the crank off and measure form the middle of the shaft to the middle of the pedal shaft. Cheers