I was wondering if my position is right? I can't seem to get comfortable on the bike, I often feel cramped. I think I may have a leg length discrepancy. Any help appreciated.

side view 1
side view 2
front
back

thanks

I think your seat is a bit high, since I see your hips rocking a bit.

It looks like your saddle may be a bit too far forward since your knee is significantly in front of the pedal axle. KOPS is a starting point but your's looks like it may be too far forward. I also think your saddle may be a bit too high but not by much.

Leg length difference can be fixed by putting a shim under your cleat. Google "bike cleat shims."

Saddle looks low to me. Hip rocking probably a function of not pedaling smooth circles. Try to pedal one-legged for a couple minutes and see if you keep a tight chain all the way around. Otherwise looks very good to me.